mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Re: Review Request 70001: Fixed an inaccurate comment in agent code.
Date Mon, 18 Feb 2019 12:05:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70001/#review212898
-----------------------------------------------------------


Ship it!




Ship It!

- Andrei Budnik


On Feb. 18, 2019, 8:15 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70001/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2019, 8:15 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Gilbert Song.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Given that `state::checkpoint` is atomic, an empty file could occur
> in case of slave host is hard rebooted after the file is created but
> before the data is synced on disk rather than slave process died.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp 7b8030a5573a822975a0ba1bfc72f50bcc7098ae

>   src/slave/state.cpp 92f777560cb9c85bfa239ba7847bb14b421fe0e7 
> 
> 
> Diff: https://reviews.apache.org/r/70001/diff/1/
> 
> 
> Testing
> -------
> 
> Not a functional change.
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message