mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 70000: Fixed verify-reviews.py to not abort review verification prematurely.
Date Sun, 17 Feb 2019 18:55:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70000/#review212886
-----------------------------------------------------------



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['69998', '69999', '70000']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2895/mesos-review-70000

Relevant logs:

- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2895/mesos-review-70000/logs/mesos-tests.log):

```
W0217 18:55:33.626559 56944 slave.cpp:3928] Ignoring shutdown framework 43b9b291-43af-44b5-bc2a-ebe409702598-0000
because it is terminating
I0217 18:55:33.628559 44756 hierarchical.cpp:390] Removed framework 43b9b291-43af-44b5-bc2a-ebe409702598-0000
I0217 18:55:33.628559 56380 master.cpp:1269] Agent 43b9b291-43af-44b5-bc2a-ebe409702598-S0
at slave(491)@192.10.1.6:55485 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
disconnected
I0217 18:55:33.629566 56380 master.cpp:3292] Disconnecting agent 43b9b291-43af-44b5-bc2a-ebe409702598-S0
at slave(491)@192.10.1.6:55485 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0217 18:55:33.629566 56380 master.cpp:3311] Deactivating agent 43b9b291-43af-44b5-bc2a-ebe409702598-S0
at slave(491)@192.10.1.6:55485 (windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0217 18:55:33.629566 49104 hierarchical.cpp:827] Agent 43b9b291-43af-44b5-bc2a-ebe409702598-S0
deactivated
I0217 18:55:33.630580 49104 containerizer.cpp:2526] Destroying container 7c684b00-4f8b-491b-bdd7-8ca85104cbe5
in RUNNING state
I0217 18:55:33.630580 49104 containerizer.cpp:3193] Transitioning the state of container 7c684b00-4f8b-491b-bdd7-8ca85104cbe5
from RUNNING to DESTROYING
I0217 18:55:33.631814 49104 launcher.cpp:161] Asked to destroy container 7c684b00-4f8b-491b-bdd7-8ca85104cbe5
W0217 18:55:33.632580 56768 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=2112
to peer '192.10.1.6:57429': IO failed with error code: The specified network name is no longer
available.

W0217 18:55:33.632580 56768 process.cpp:1423] Failed to recv on socket WindowsFD::Type::SOCKET=2176
to peer '192.10.1.6:57428': IO failed w[       OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
(686 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (705 ms total)

[----------] Global test environment tear-down
[==========] 1112 tests from 105 test cases ran. (517335 ms total)
[  PASSED  ] 1111 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage

 1 FAILED TEST
  YOU HAVE 232 DISABLED TESTS

ith error code: The specified network name is no longer available.

I0217 18:55:33.715597 56380 containerizer.cpp:3032] Container 7c684b00-4f8b-491b-bdd7-8ca85104cbe5
has exited
I0217 18:55:33.745697 56944 master.cpp:1109] Master terminating
I0217 18:55:33.746562 52864 hierarchical.cpp:678] Removed agent 43b9b291-43af-44b5-bc2a-ebe409702598-S0
I0217 18:55:34.423573 56768 process.cpp:927] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On Feb. 17, 2019, 9:48 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70000/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2019, 9:48 a.m.)
> 
> 
> Review request for mesos, Till Toenshoff and Vinod Kone.
> 
> 
> Bugs: MESOS-9582
>     https://issues.apache.org/jira/browse/MESOS-9582
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously `support/verify-reviews.py` would abort prematurely
> whenever a review a patch could not be applied. This was due to
> the `shell` function used to call `support/apply-reviews.py` invoking
> `exit(1)` on the first error which stopped iteration over all
> outstanding reviews.
> 
> In this patch that explicit call to `exit` is removed, and instead we
> let a possible `subprocess.CalledProcessError` propagate up for it to
> be handled at a higher level. Currently this will post a note on the
> review in question to (1) notify the submitter, and (2) prevent the
> review from being checked again.
> 
> With the changes here the script will not stop verify reviews in such
> cases.
> 
> 
> Diffs
> -----
> 
>   support/verify-reviews.py a88a91f8ecb3794846d2d5eddee27ada770d55b9 
> 
> 
> Diff: https://reviews.apache.org/r/70000/diff/1/
> 
> 
> Testing
> -------
> 
> Ran the script (with a dummy user and password) on today's reviewboard state. The script
attempted to post a review on the last patch in the chain instead of aborting (see the `TODO`
in the code on why we weren't able to diagnose the issue in the faulty patch with the current
implementation).
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message