mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 69981: Fixed a flaky test `MasterQuotaTest.RemoveSingleQuota`.
Date Fri, 15 Feb 2019 22:11:44 GMT


> On Feb. 14, 2019, 9:12 a.m., Benjamin Mahler wrote:
> > src/tests/master_quota_tests.cpp
> > Lines 524-525 (patched)
> > <https://reviews.apache.org/r/69981/diff/2/?file=2125212#file2125212line524>
> >
> >     Hm.. we're actually waiting for the 200 OK, is this needed because the http
handler doesn't wait for the allocator to finish processing the update?
> >     
> >     Probably we should spell it out here and below so it's clear

Updated the comment saying we are waiting specifically for the metrics update to finish, which
is not on the path for 200 OK.


- Meng


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69981/#review212833
-----------------------------------------------------------


On Feb. 13, 2019, 4:27 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69981/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2019, 4:27 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9143
>     https://issues.apache.org/jira/browse/MESOS-9143
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The test is flaky due to a race between metrics update
> and metrics query.
> 
> This patch adds clock settle to ensure quota update and
> removal are fully processed (including metrics updates) before
> continuing with the metrics query.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_quota_tests.cpp 354a9e988c3e4cdf94c99170d2abb7cb17f9e11a 
> 
> 
> Diff: https://reviews.apache.org/r/69981/diff/2/
> 
> 
> Testing
> -------
> 
> Test ran continuously without failure
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message