mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Re: Review Request 69994: Added a test `ROOT_EmptyCheckpointFileSlaveRecovery`.
Date Fri, 15 Feb 2019 13:39:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69994/#review212869
-----------------------------------------------------------




src/tests/containerizer/docker_volume_isolator_tests.cpp
Lines 691 (patched)
<https://reviews.apache.org/r/69994/#comment298759>

    The comment from the previous patch that describes the root cause of empty files might
be helpful to understand why we need this test. This comment can be copy-pasted here.



src/tests/containerizer/docker_volume_isolator_tests.cpp
Lines 745-748 (patched)
<https://reviews.apache.org/r/69994/#comment298758>

    If we need "options", we could pass `{{"iops", "150"}}` directly to the first invokation
of `createDockerVolume`?



src/tests/containerizer/docker_volume_isolator_tests.cpp
Lines 851 (patched)
<https://reviews.apache.org/r/69994/#comment298757>

    Consider `Owned<MockDockerVolumeDriverClient> mockClient`?


- Andrei Budnik


On Feb. 15, 2019, 9:08 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69994/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2019, 9:08 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Gilbert Song.
> 
> 
> Bugs: MESOS-9507
>     https://issues.apache.org/jira/browse/MESOS-9507
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test `ROOT_EmptyCheckpointFileSlaveRecovery`.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_volume_isolator_tests.cpp 1503290bf62d5718df0a530a660b519649e76789

> 
> 
> Diff: https://reviews.apache.org/r/69994/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> This test will fail without the patch https://reviews.apache.org/r/69972
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message