mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 69909: Tested unreachable task behavior on agent GC.
Date Thu, 14 Feb 2019 22:46:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69909/#review212850
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/partition_tests.cpp
Lines 3086-3089 (patched)
<https://reviews.apache.org/r/69909/#comment298734>

    This is in the middle of the code related to the explicit reconciliation.
    
    I would move it to line 3077.
    
    Consider explaining a bit more on the comment:
    
    ``slave1` has been garbage collected, so the task shoudl have been removed from the master's
unreachable tasks list`


- Gastón Kleiman


On Feb. 6, 2019, 8:41 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69909/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2019, 8:41 a.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Greg Mann.
> 
> 
> Bugs: MESOS-8887
>     https://issues.apache.org/jira/browse/MESOS-8887
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated `PartitionTest, RegistryGcByCount` test. This test fails
> without the previous patch.
> 
> 
> Diffs
> -----
> 
>   src/tests/partition_tests.cpp 15af47b7d4328861a7523e669c2afc6a6574166b 
> 
> 
> Diff: https://reviews.apache.org/r/69909/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message