mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 69907: Fixed variable names in `Master::_doRegistryGC()`.
Date Thu, 14 Feb 2019 22:31:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69907/#review212848
-----------------------------------------------------------


Fix it, then Ship it!





src/master/master.cpp
Line 1799 (original), 1799 (patched)
<https://reviews.apache.org/r/69907/#comment298733>

    Can you fix it here too?


- Gastón Kleiman


On Feb. 6, 2019, 8:35 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69907/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2019, 8:35 a.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Substituted `slave` with `slaveId` to be consistent with the code base.
> No functional changes.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 4c9ef2528d0ab74b565dcb03d05c5189d0aa0c0f 
> 
> 
> Diff: https://reviews.apache.org/r/69907/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message