mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 69862: Validated static framework offer filters.
Date Thu, 14 Feb 2019 18:41:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69862/#review212834
-----------------------------------------------------------




src/common/validation.cpp
Lines 622-625 (patched)
<https://reviews.apache.org/r/69862/#comment298726>

    Hm.. this should be allowed? This is how the framework can express an override of the
global min with no minimum



src/common/validation.cpp
Lines 630-632 (patched)
<https://reviews.apache.org/r/69862/#comment298725>

    this seems good!
    
    Maybe also a comment:
    
    ```
    We disallow an empty quantity since that is equivalent to an empty set (i.e. override
of "no minimum")
    ```


- Benjamin Mahler


On Feb. 13, 2019, 10:31 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69862/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2019, 10:31 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Meng Zhu.
> 
> 
> Bugs: MESOS-9523
>     https://issues.apache.org/jira/browse/MESOS-9523
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds validation to framework-specified static offer filters.
> In particular we enforce that minimal resource quantities cannot be
> negative.
> 
> 
> Diffs
> -----
> 
>   src/common/validation.hpp 5929ac24fa7d7d2f7f08bc30c5071716e6cf46cb 
>   src/common/validation.cpp 4a64fc8ac83fd741eb2cbc70772322b347dbcb4e 
>   src/master/validation.hpp a5bdff6a9301631dac9970568a1346460939c861 
>   src/master/validation.cpp 4a699f06a3e47ff50b356ce6ff470d1c4e13b02e 
>   src/tests/common_validation_tests.cpp 97466ab38f3156155655520c81b17cc6ec2cd779 
>   src/tests/master_validation_tests.cpp b34e88f12a8959989aea5c180b15f8ae2933d33f 
> 
> 
> Diff: https://reviews.apache.org/r/69862/diff/4/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message