mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 69656: Fixed test `MesosContainerizerSlaveRecoveryTest.ResourceStatistics`.
Date Thu, 14 Feb 2019 01:30:03 GMT


> On Jan. 14, 2019, 11:41 a.m., Joseph Wu wrote:
> > src/tests/slave_recovery_tests.cpp
> > Lines 5152-5153 (original), 5153-5154 (patched)
> > <https://reviews.apache.org/r/69656/diff/1/?file=2117263#file2117263line5153>
> >
> >     Not terribly impactful for the test, but since you are capturing the TASK_STARTING
update, you could check the status before the TASK_RUNNING one.
> >     ```
> >       AWAIT_READY(statusStarting);
> >       EXPECT_EQ(TASK_STARTING, statusStarting->state());
> >     ```

Done.


- Meng


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69656/#review211962
-----------------------------------------------------------


On Jan. 2, 2019, 9:16 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69656/
> -----------------------------------------------------------
> 
> (Updated Jan. 2, 2019, 9:16 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Till Toenshoff.
> 
> 
> Bugs: MESOS-5048
>     https://issues.apache.org/jira/browse/MESOS-5048
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `MesosContainerizerSlaveRecoveryTest.ResourceStatistics` is flaky
> due to a race between executor shutdown (due to never getting any
> tasks) and the test querying resource statistics. If the executor
> is shutdown before the statistics query, the test will fail.
> 
> This patch fixes the test by explicitly waiting for the task to
> be delivered and task status transition to `TASK_RUNNING` before
> restarting the agent. This way, the executor will not be shutdown
> after agent restart. Hence there will be no race.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_recovery_tests.cpp 0eb47e2bdf6a46fc21b59bb85b4b89181087ccd3 
> 
> 
> Diff: https://reviews.apache.org/r/69656/diff/1/
> 
> 
> Testing
> -------
> 
> ran `MesosContainerizerSlaveRecoveryTest.ResourceStatistics` continuously without failure.
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message