mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 69978: Added garbage collection of terminated operations status update streams.
Date Wed, 13 Feb 2019 23:15:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69978/
-----------------------------------------------------------

(Updated Feb. 13, 2019, 3:15 p.m.)


Review request for mesos, Chun-Hung Hsiao and Greg Mann.


Changes
-------

Fixed typos in the commit message.


Bugs: MESOS-9574
    https://issues.apache.org/jira/browse/MESOS-9574


Repository: mesos


Description (updated)
-------

Make the agent garbage collect an operation status update stream once
a terminal status update is acknowledged.

This patch also improves the logging of acknowledgement failures and the
readability of the `Slave::operationStatusAcknowledgement` method.


Diffs (updated)
-----

  src/slave/slave.cpp e3c2c005d865b5c333e92e50e49ef398fe06ad79 


Diff: https://reviews.apache.org/r/69978/diff/2/

Changes: https://reviews.apache.org/r/69978/diff/1-2/


Testing
-------

Manual testing + existing tests still pass.


Thanks,

Gastón Kleiman


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message