mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <>
Subject Re: Review Request 69968: Copied operation removal logic in agent removal code path.
Date Wed, 13 Feb 2019 22:46:47 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Feb. 13, 2019, 2:46 p.m.)

Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann.


Did some local testing to commit this patch independently of the chain.

Bugs: MESOS-9557

Repository: mesos


There are two code paths the master can follow to remove an agent
from its memory:
- When the agent sends an UnregisterSlaveMessage or tries to register
  as a new agent,
- Or, when an agent is marked unreachable/gone.

The first code path did not clean up operation state completely,
resulting in leaking some memory in the master's Framework structs.


  src/master/master.cpp 014e0e053cdf5c53a5ef8d63300205a121bed319 


Testing (updated)

make check


Joseph Wu

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message