mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 69897: Made SLRP `PublishResourcesRecovery` test to check volume cleanup.
Date Wed, 13 Feb 2019 21:22:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69897/
-----------------------------------------------------------

(Updated Feb. 13, 2019, 9:22 p.m.)


Review request for mesos and Benjamin Bannier.


Changes
-------

Addressed Benjamin's comments and fixed a compilation error.


Bugs: MESOS-9565
    https://issues.apache.org/jira/browse/MESOS-9565


Repository: mesos


Description (updated)
-------

This patch renames the `ROOT_PublishResourcesRecovery` test to
`ROOT_CreateDestroyPersistentMountVolumeWithRecovery` and makes it
verify that the persistent volume is cleaned up with `DESTROY` after
recovery.

NOTE: The `filesystem/linux` isolator has been removed from the test
because it is not necessary for the test. However, the root privilege is
still required by the test CSI plugin for bind-mounting.


Diffs (updated)
-----

  src/tests/storage_local_resource_provider_tests.cpp fb001aa8d32d1a0a03014a35772fe10b65ce8d9a



Diff: https://reviews.apache.org/r/69897/diff/3/

Changes: https://reviews.apache.org/r/69897/diff/2-3/


Testing
-------

`make check`

Run in repetition with ~250 iterations. (It will fail with "too many open files" with more
iterations because of https://issues.apache.org/jira/browse/MESOS-8428.


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message