mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <>
Subject Re: Review Request 69896: Made SLRP `PublishResourcesReboot` test to check persistent volume cleanup.
Date Wed, 13 Feb 2019 21:20:35 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Feb. 13, 2019, 9:20 p.m.)

Review request for mesos and Benjamin Bannier.


Addressed Benjamin's comments and fixed a compilation error.

Bugs: MESOS-9565

Repository: mesos

Description (updated)

This patch renames the `ROOT_PublishResourcesReboot` test to
`ROOT_CreateDestroyPersistentMountVolumeWithReboot` and makes it verify
that the persistent volume is cleaned up with `DESTROY` after a reboot.

NOTE: The `filesystem/linux` isolator has been removed from the test
because it is not necessary for the test. However, the root privilege is
still required by the test CSI plugin for bind-mounting.

Diffs (updated)

  src/tests/storage_local_resource_provider_tests.cpp fb001aa8d32d1a0a03014a35772fe10b65ce8d9a




`make check`

Run in repetition with ~200 repetitions.

Manually injected some delay in the SLRP profile reconciliation loop to test the behavior.
Without waiting for the 3rd `UpdateSlaveMessage` the test flake would manifest, and with the
trick the flake is gone.


Chun-Hung Hsiao

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message