mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 69968: Copied operation removal logic in agent removal code path.
Date Wed, 13 Feb 2019 03:45:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69968/#review212783
-----------------------------------------------------------



PASS: Mesos patch 69968 was successfully built and tested.

Reviews applied: `['69968']`

All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2880/mesos-review-69968

- Mesos Reviewbot Windows


On Feb. 13, 2019, 10:05 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69968/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2019, 10:05 a.m.)
> 
> 
> Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann.
> 
> 
> Bugs: MESOS-9557
>     https://issues.apache.org/jira/browse/MESOS-9557
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> There are two code paths the master can follow to remove an agent
> from its memory:
> - When the agent sends an UnregisterSlaveMessage or tries to register
>   as a new agent,
> - Or, when an agent is marked unreachable/gone.
> 
> The first code path did not clean up operation state completely,
> resulting in leaking some memory in the master's Framework structs.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 014e0e053cdf5c53a5ef8d63300205a121bed319 
> 
> 
> Diff: https://reviews.apache.org/r/69968/diff/1/
> 
> 
> Testing
> -------
> 
> See last patch in chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message