mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 69964: Added tests related to operation feedback agent capabilities.
Date Wed, 13 Feb 2019 02:38:35 GMT


> On Feb. 13, 2019, 1:49 a.m., Gastón Kleiman wrote:
> > src/tests/master_tests.cpp
> > Lines 9753 (patched)
> > <https://reviews.apache.org/r/69964/diff/1/?file=2124998#file2124998line9753>
> >
> >     Can we check here that the framework doesn't get any operation status updates?

Since the test drops `UpdateOperationStatusMessage`s in order to simulate an old agent, I
don't think this is a meaningful thing to do here. Dropping.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69964/#review212779
-----------------------------------------------------------


On Feb. 12, 2019, 11:42 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69964/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2019, 11:42 p.m.)
> 
> 
> Review request for mesos and Gastón Kleiman.
> 
> 
> Bugs: MESOS-9535
>     https://issues.apache.org/jira/browse/MESOS-9535
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> These tests verify that master and agent behavior is correct
> during a downgrade of an agent to one which does not have the
> AGENT_OPERATION_FEEDBACK capability, and when a new agent's
> capabilities are altered such that it no longer has the
> RESOURCE_PROVIDER capability set.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_tests.cpp 9584fa38c6e9ea26b5b6937199fe4679325ef55e 
> 
> 
> Diff: https://reviews.apache.org/r/69964/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message