mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 69957: Updated master operation handling to account for new agent capability.
Date Wed, 13 Feb 2019 02:37:45 GMT


> On Feb. 13, 2019, 12:08 a.m., Gastón Kleiman wrote:
> > src/master/master.cpp
> > Lines 4372-4375 (original), 4373-4376 (patched)
> > <https://reviews.apache.org/r/69957/diff/2/?file=2124997#file2124997line4373>
> >
> >     The semantics of these capabilities is not very intuitive; we should update
our documentation with a good explanation.

Good call; I added a patch to the end of this chain: https://reviews.apache.org/r/69969/


> On Feb. 13, 2019, 12:08 a.m., Gastón Kleiman wrote:
> > src/master/master.cpp
> > Line 8725 (original)
> > <https://reviews.apache.org/r/69957/diff/2/?file=2124997#file2124997line8729>
> >
> >     Would the following assertion hold?
> >     
> >     `CHECK(slave->capabilities.resourceProvider || slave->capabilities.agentOperationFeedback)`

Yep! Good call.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69957/#review212772
-----------------------------------------------------------


On Feb. 13, 2019, 2:37 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69957/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2019, 2:37 a.m.)
> 
> 
> Review request for mesos and Gastón Kleiman.
> 
> 
> Bugs: MESOS-9535
>     https://issues.apache.org/jira/browse/MESOS-9535
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Since the new AGENT_OPERATION_FEEDBACK capability has been
> made required for agent startup, we need to update the way
> the master handles validation of incoming operations and
> acknowledgement calls to account for cases where each of
> the AGENT_OPERATION_FEEDBACK and RESOURCE_PROVIDER
> capabilities are enabled/disabled.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp cf2210ec26642028d5e4fb7fc1841eb0a1ed3396 
> 
> 
> Diff: https://reviews.apache.org/r/69957/diff/3/
> 
> 
> Testing
> -------
> 
> Testing details at the end of this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message