mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Review Request 69962: Added cleanup logic for orphaned operations.
Date Wed, 13 Feb 2019 02:15:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69962/
-----------------------------------------------------------

Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann.


Bugs: MESOS-9542
    https://issues.apache.org/jira/browse/MESOS-9542


Repository: mesos


Description
-------

The resources used by orphaned operations are not accounted for
in the Slave struct's `usedResources`, and must be treated differently
when cleaning up the operation.  Removal of non-terminal orphan
operations will instead augment the `totalResources`.

NOTE: The only codepath that can remove non-terminal operations is
when removing the agent.  In this case, there is no need to update
the allocator with the augmented `totalResources`.


Diffs
-----

  src/master/master.cpp 014e0e053cdf5c53a5ef8d63300205a121bed319 


Diff: https://reviews.apache.org/r/69962/diff/1/


Testing
-------

See last patch in chain.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message