mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 69957: Updated master operation handling to account for new agent capability.
Date Wed, 13 Feb 2019 00:08:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69957/#review212772
-----------------------------------------------------------




src/master/master.cpp
Lines 4372-4375 (original), 4373-4376 (patched)
<https://reviews.apache.org/r/69957/#comment298681>

    The semantics of these capabilities is not very intuitive; we should update our documentation
with a good explanation.



src/master/master.cpp
Line 6419 (original), 6422-6423 (patched)
<https://reviews.apache.org/r/69957/#comment298682>

    I think the following might be a bit more useful for operators:
    
    ```
        LOG(WARNING)
          << "Cannot send operation status update acknowledgement for status "
          << statusUuid << " of operation '" << operationId << "'"
          << " of framework " << *framework << " to agent " << slaveId
          << " because the agent does not have the RESOURCE_PROVIDER"
          << " and AGENT_OPERATION_FEEDBACK capabilities";
    ```
    
    If they get that, then it might be easier for them to debug missing capabilities.



src/master/master.cpp
Line 8725 (original)
<https://reviews.apache.org/r/69957/#comment298683>

    Would the following assertion hold?
    
    `CHECK(slave->capabilities.resourceProvider || slave->capabilities.agentOperationFeedback)`


- Gastón Kleiman


On Feb. 12, 2019, 3:39 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69957/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2019, 3:39 p.m.)
> 
> 
> Review request for mesos and Gastón Kleiman.
> 
> 
> Bugs: MESOS-9535
>     https://issues.apache.org/jira/browse/MESOS-9535
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Since the new AGENT_OPERATION_FEEDBACK capability has been
> made required for agent startup, we need to update the way
> the master handles validation of incoming operations and
> acknowledgement calls to account for cases where each of
> the AGENT_OPERATION_FEEDBACK and RESOURCE_PROVIDER
> capabilities are enabled/disabled.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp cf2210ec26642028d5e4fb7fc1841eb0a1ed3396 
> 
> 
> Diff: https://reviews.apache.org/r/69957/diff/2/
> 
> 
> Testing
> -------
> 
> Testing details at the end of this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message