mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 69892: Made SLRP recover node-published volumes after reboot.
Date Tue, 12 Feb 2019 20:42:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69892/
-----------------------------------------------------------

(Updated Feb. 12, 2019, 8:42 p.m.)


Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu.


Changes
-------

Addressed Benjamin's comments.


Bugs: MESOS-9544
    https://issues.apache.org/jira/browse/MESOS-9544


Repository: mesos


Description
-------

If a CSI volume has been node-published before a reboot, SLRP will now
try to bring it back to node-published again. This is important to
perform synchronous persistent volume cleanup for `DESTROY`.

To achieve this, in addition to keeping track of the boot ID when a CSI
volume is node-staged in `VolumeState.vol_ready_boot_id` (formerly
`VolumeState.boot_id`), SLRP now also keeps track of the boot ID when
the volume is node-published. This helps SLRP to better determine if a
volume has been published before reboot.


Diffs (updated)
-----

  src/csi/state.proto 264a5657dd37605a6f3bdadd0e8d18ba9673191a 
  src/resource_provider/storage/provider.cpp 09a710d668a5a7460b6c4e4fa32d3829dca7ac55 


Diff: https://reviews.apache.org/r/69892/diff/3/

Changes: https://reviews.apache.org/r/69892/diff/2-3/


Testing
-------

`make check`

Testing for publish failures will be done later in chain.


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message