mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 69892: Made SLRP recover node-published volumes after reboot.
Date Tue, 12 Feb 2019 20:28:44 GMT


> On Feb. 12, 2019, 1:24 p.m., Benjamin Bannier wrote:
> > src/resource_provider/storage/provider.cpp
> > Lines 945-950 (patched)
> > <https://reviews.apache.org/r/69892/diff/2/?file=2124901#file2124901line953>
> >
> >     Hmm, executing this only on the `!node_publish_required` path seems asymmetric.
Could we install this unconditionally?
> 
> Chun-Hung Hsiao wrote:
>     Good suggestion. Sure let me add logging for the other case as well.

However, the `recover` callback here is to intentionally skip the failure for the `!node_publish_required`
case. This makes the behavior more consistent with other scenarios, e.g., when the SLRP fails
to publish or delete a volume, it returns the error but continue to run, so it should do so
even if there's a recovery in between.


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69892/#review212736
-----------------------------------------------------------


On Feb. 12, 2019, 5:05 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69892/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2019, 5:05 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu.
> 
> 
> Bugs: MESOS-9544
>     https://issues.apache.org/jira/browse/MESOS-9544
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> If a CSI volume has been node-published before a reboot, SLRP will now
> try to bring it back to node-published again. This is important to
> perform synchronous persistent volume cleanup for `DESTROY`.
> 
> To achieve this, in addition to keeping track of the boot ID when a CSI
> volume is node-staged in `VolumeState.vol_ready_boot_id` (formerly
> `VolumeState.boot_id`), SLRP now also keeps track of the boot ID when
> the volume is node-published. This helps SLRP to better determine if a
> volume has been published before reboot.
> 
> 
> Diffs
> -----
> 
>   src/csi/state.proto 264a5657dd37605a6f3bdadd0e8d18ba9673191a 
>   src/resource_provider/storage/provider.cpp 09a710d668a5a7460b6c4e4fa32d3829dca7ac55

> 
> 
> Diff: https://reviews.apache.org/r/69892/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> Testing for publish failures will be done later in chain.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message