mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 69905: Added a SLRP unit test for failed persistent volume cleanup.
Date Tue, 12 Feb 2019 17:40:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69905/#review212745
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/storage_local_resource_provider_tests.cpp
Lines 2814-2815 (patched)
<https://reviews.apache.org/r/69905/#comment298644>

    Is this actually needed? With just the default filters the test still passes. Could you
either remove this or document where it is needed (e.g., to address flakiness)?


- Benjamin Bannier


On Feb. 6, 2019, 6:38 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69905/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2019, 6:38 a.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-9544
>     https://issues.apache.org/jira/browse/MESOS-9544
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Test `ROOT_CreateDestroyPersistentMountVolumeFailed` verifies that if
> SLRP fails to clean up a persistent volume, `DESTROY` would fail, the
> persistent volume would remain, and depended operations will be dropped.
> 
> 
> Diffs
> -----
> 
>   src/tests/storage_local_resource_provider_tests.cpp fb001aa8d32d1a0a03014a35772fe10b65ce8d9a

> 
> 
> Diff: https://reviews.apache.org/r/69905/diff/4/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message