mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 69904: Extracted common offer matching functions from SLRP tests.
Date Tue, 12 Feb 2019 15:16:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69904/#review212744
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/storage_local_resource_provider_tests.cpp
Lines 334 (patched)
<https://reviews.apache.org/r/69904/#comment298642>

    Could you briefly document what these do?
    
    We could just declare these outside of the class in this file instead of them being `static`.


- Benjamin Bannier


On Feb. 12, 2019, 6:26 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69904/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2019, 6:26 a.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-9544
>     https://issues.apache.org/jira/browse/MESOS-9544
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch extracts lambda functions `isStoragePool`, `isMountDisk` and
> `isPreprovisionedVolume` from all tests and makes them common utitily
> functions in the test fixture.
> 
> 
> Diffs
> -----
> 
>   src/tests/storage_local_resource_provider_tests.cpp fb001aa8d32d1a0a03014a35772fe10b65ce8d9a

> 
> 
> Diff: https://reviews.apache.org/r/69904/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message