mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 69898: Updated `CreateDestroyDisk*` SLRP tests to test pipelined operations.
Date Tue, 12 Feb 2019 15:10:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69898/#review212743
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/storage_local_resource_provider_tests.cpp
Line 818 (original), 817 (patched)
<https://reviews.apache.org/r/69898/#comment298638>

    Is this needed?



src/tests/storage_local_resource_provider_tests.cpp
Lines 879-880 (original), 873-874 (patched)
<https://reviews.apache.org/r/69898/#comment298639>

    This is not symmetric with how this disk was created (`reserve`, then `create_disk`).
If we decide to deliberately test a switched teardown order here we should probably add a
comment.



src/tests/storage_local_resource_provider_tests.cpp
Lines 1024 (patched)
<https://reviews.apache.org/r/69898/#comment298640>

    Does the first sentence document that _when we see the extra pool in offers, we have observed
that the RP has seen a profile_? We should make the reason we need this a little crisper.
    
    Also `s/setup/set up/`.



src/tests/storage_local_resource_provider_tests.cpp
Lines 1094-1095 (patched)
<https://reviews.apache.org/r/69898/#comment298641>

    Could document ordering of `unreserve` and `destroy_disk` here.


- Benjamin Bannier


On Feb. 12, 2019, 6:26 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69898/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2019, 6:26 a.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-9544
>     https://issues.apache.org/jira/browse/MESOS-9544
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch extends the code coverage of the `CreateDestroyDisk` and
> `CreateDestroyDiskRecovery` tests by testing pipelined `RESERVE`,
> `CREATE`, `DESTROY` and `UNRESERVE` operations along with `CREATE_DISK`
> and `DESTROY_DISK`. It also renames `CreateDestroyDiskRecovery` to
> `CreateDestroyDiskWithRecovery` for consistency.
> 
> 
> Diffs
> -----
> 
>   src/tests/storage_local_resource_provider_tests.cpp fb001aa8d32d1a0a03014a35772fe10b65ce8d9a

> 
> 
> Diff: https://reviews.apache.org/r/69898/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> Run in repetition
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message