mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 69897: Made SLRP `PublishResourcesRecovery` test to check volume cleanup.
Date Tue, 12 Feb 2019 14:33:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69897/#review212742
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/storage_local_resource_provider_tests.cpp
Line 2011 (original)
<https://reviews.apache.org/r/69897/#comment298635>

    Ditto, see previous two RRs.



src/tests/storage_local_resource_provider_tests.cpp
Lines 2205 (patched)
<https://reviews.apache.org/r/69897/#comment298636>

    See previous RR.



src/tests/storage_local_resource_provider_tests.cpp
Line 2255 (original), 2283 (patched)
<https://reviews.apache.org/r/69897/#comment298637>

    Could us operation status update, see previous RRs.


- Benjamin Bannier


On Feb. 12, 2019, 6:24 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69897/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2019, 6:24 a.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-9544
>     https://issues.apache.org/jira/browse/MESOS-9544
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch renames the `ROOT_PublishResourcesRecovery` test to
> `ROOT_CreateDestroyPersistentMountVolumeWithRecovery` and makes it
> verify that the persistent volume is cleaned up with `DESTROY` after
> recovery.
> 
> 
> Diffs
> -----
> 
>   src/tests/storage_local_resource_provider_tests.cpp fb001aa8d32d1a0a03014a35772fe10b65ce8d9a

> 
> 
> Diff: https://reviews.apache.org/r/69897/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> Run in repetition with ~250 iterations. (It will fail with "too many open files" with
more iterations because of https://issues.apache.org/jira/browse/MESOS-8428.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message