mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 69896: Made SLRP `PublishResourcesReboot` test to check persistent volume cleanup.
Date Tue, 12 Feb 2019 14:30:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69896/#review212740
-----------------------------------------------------------




src/tests/storage_local_resource_provider_tests.cpp
Line 2282 (original)
<https://reviews.apache.org/r/69896/#comment298632>

    Not mentioned anywhere.



src/tests/storage_local_resource_provider_tests.cpp
Lines 2519-2523 (patched)
<https://reviews.apache.org/r/69896/#comment298634>

    Could you briefly document _why_ we do this? You could probably merge this note with the
one mentioning MESOS-9553.



src/tests/storage_local_resource_provider_tests.cpp
Line 2564 (original), 2598 (patched)
<https://reviews.apache.org/r/69896/#comment298633>

    Wait for an operation status update here?


- Benjamin Bannier


On Feb. 12, 2019, 6:22 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69896/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2019, 6:22 a.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-9544
>     https://issues.apache.org/jira/browse/MESOS-9544
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch renames the `ROOT_PublishResourcesReboot` test to
> `ROOT_CreateDestroyPersistentMountVolumeWithReboot` and makes it verify
> that the persistent volume is cleaned up with `DESTROY` after a reboot.
> 
> 
> Diffs
> -----
> 
>   src/tests/storage_local_resource_provider_tests.cpp fb001aa8d32d1a0a03014a35772fe10b65ce8d9a

> 
> 
> Diff: https://reviews.apache.org/r/69896/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> Run in repetition with ~200 repetitions.
> 
> Manually injected some delay in the SLRP profile reconciliation loop to test the behavior.
Without waiting for the 3rd `UpdateSlaveMessage` the test flake would manifest, and with the
trick the flake is gone.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message