mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 69895: Made SLRP `PublishResources` test to check persistent volume cleanup.
Date Tue, 12 Feb 2019 14:21:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69895/#review212739
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/storage_local_resource_provider_tests.cpp
Line 1799 (original)
<https://reviews.apache.org/r/69895/#comment298629>

    This seems unrelated to anything in the commit message (but worthwhile).



src/tests/storage_local_resource_provider_tests.cpp
Lines 1974 (patched)
<https://reviews.apache.org/r/69895/#comment298630>

    Either `CSI volume` here, or `MOUNT volume` below.



src/tests/storage_local_resource_provider_tests.cpp
Lines 1984-1985 (patched)
<https://reviews.apache.org/r/69895/#comment298631>

    It looks like we use offers for synchronization here. Using a status update like above
seems clearer and closer to what we want to me.


- Benjamin Bannier


On Feb. 12, 2019, 6:20 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69895/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2019, 6:20 a.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-9544
>     https://issues.apache.org/jira/browse/MESOS-9544
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch renames the `ROOT_PublishResources` test to
> `ROOT_CreateDestroyPersistentMountVolume` and makes it verify that the
> persistent volume is cleaned up after `DESTROY`.
> 
> 
> Diffs
> -----
> 
>   src/tests/storage_local_resource_provider_tests.cpp fb001aa8d32d1a0a03014a35772fe10b65ce8d9a

> 
> 
> Diff: https://reviews.apache.org/r/69895/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message