mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 69893: Clean up persistent volumes on SLRP disks.
Date Tue, 12 Feb 2019 14:00:40 GMT


> On Feb. 5, 2019, 6:55 p.m., Benjamin Bannier wrote:
> > src/resource_provider/storage/provider.cpp
> > Lines 3244 (patched)
> > <https://reviews.apache.org/r/69893/diff/1/?file=2123916#file2123916line3246>
> >
> >     Does this break seemless upgrades? Probably okay, but still something worth
documenting in the upgrades guide.
> 
> Chun-Hung Hsiao wrote:
>     This depends on what we'll do for https://reviews.apache.org/r/69892/#comment298376.
In the current proposal where there are separated boot IDs, this won't introduce any upgrade
issue since it will be empty anyway. During SLRP recovery, it would treat an existing published
volume as `VOL_READY` but not `PUBLISHED` and will call `NodePublishVolume` again. But this
is okay since `NodePublishVolume` is idempotent.
> 
> Chun-Hung Hsiao wrote:
>     This is a bug fix and will be backported to 1.7.x, so I'm not sure how to properly
document this in `upgrades.md`. I've added some documentation to the commit message, and will
also add that to the MESOS ticket and the CHANGELOG when committing the fix. Would this be
enough?

Sg!


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69893/#review212558
-----------------------------------------------------------


On Feb. 12, 2019, 6:19 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69893/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2019, 6:19 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu.
> 
> 
> Bugs: MESOS-9544
>     https://issues.apache.org/jira/browse/MESOS-9544
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch limits SLRP to only support persistent volumes on MOUNT
> disks, and makes it clean up data in persistent volumes when processing
> `DESTROY` operations.
> 
> NOTE: Persistent volumes backed by CSI disks that are created before
> upgrading to a Mesos version that does not include this fix are subject
> to data leakage. To ensure data security, these persistent volume must
> be consumed by a task at least once after the upgrade before being
> destroyed.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/storage/provider.cpp 09a710d668a5a7460b6c4e4fa32d3829dca7ac55

>   src/resource_provider/storage/provider_process.hpp 36187fb4a25c49653530ee286fa9c1663177fbc6

> 
> 
> Diff: https://reviews.apache.org/r/69893/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> More testing done later in chain.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message