mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 69866: Updated SLRP test `ProfileDisappeared` to request operation feedback.
Date Tue, 12 Feb 2019 12:19:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69866/#review212735
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/storage_local_resource_provider_tests.cpp
Lines 18 (patched)
<https://reviews.apache.org/r/69866/#comment298612>

    Only tangentially related to the changes here, but LGTM.
    
    If we do this we should also explicitly pull in the headers for other used symbols from
`std`, e.g., `list`, `string` and `vector`.



src/tests/storage_local_resource_provider_tests.cpp
Lines 1110-1112 (patched)
<https://reviews.apache.org/r/69866/#comment298613>

    Let's use `create` and `remove` in 1, 2, 3, also to be consistent with 4.


- Benjamin Bannier


On Feb. 12, 2019, 6:01 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69866/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2019, 6:01 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Gastón Kleiman, and Greg Mann.
> 
> 
> Bugs: MESOS-9537
>     https://issues.apache.org/jira/browse/MESOS-9537
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates `StorageLocalResourceProviderTest.ProfileDisappeared`
> to use the v1 scheduler API to request operation feedback, so MESOS-9537
> would be triggered when an outstanding `UPDATE_STATE` call from the
> resource provider races with an offer operation.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.hpp b10ec0ad62efa8980ca12693939970c2252ee814 
>   src/tests/storage_local_resource_provider_tests.cpp fb001aa8d32d1a0a03014a35772fe10b65ce8d9a

> 
> 
> Diff: https://reviews.apache.org/r/69866/diff/5/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> Ran the test ~1000 times.
> 
> This test will fail without r/69858:
> ```
> E0130 22:48:02.790385 24040 provider.cpp:2903] Failed to update status of operation (uuid:
2bf6813c-bde9-4c0e-8831-a779f5dc50ac): Mismatched framework ID for operation status update
OPERATION_DROPPED (Status UUID: 8a625c40-96e8-46e2-8050-69843032969a) for operation UUID 2bf6813c-bde9-4c0e-8831-a779f5dc50ac
on agent bfa6e505-54b7-4bb8-a8aa-99fb12291fb1-S0 (expected bfa6e505-54b7-4bb8-a8aa-99fb12291fb1-0000
got no framework ID)
> I0130 22:48:02.791590 24042 manager.cpp:163] Terminating resource provider 765391c2-9485-4614-a6e5-45e67ef7a92c
> ...
> ../../src/tests/storage_local_resource_provider_tests.cpp:1387: Failure
>       Expected: v1::OPERATION_FINISHED
>       Which is: OPERATION_FINISHED
> To be equal to: update->status().state()
>       Which is: OPERATION_ERROR
> ../../src/tests/storage_local_resource_provider_tests.cpp:1393: Failure
> Failed to wait 15secs for offers
> ...
> ../../src/tests/storage_local_resource_provider_tests.cpp:1361: Failure
> Actual function call count doesn't match EXPECT_CALL(*scheduler, offers(_, v1::scheduler::OffersHaveAnyResource(
std::bind(isStoragePool, lambda::_1, "test2"))))...
>          Expected: to be called once
>            Actual: never called - unsatisfied and active
> ```
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message