mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 69898: Updated `CreateDestroyDisk*` SLRP tests to test pipelined operations.
Date Tue, 12 Feb 2019 05:26:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69898/
-----------------------------------------------------------

(Updated Feb. 12, 2019, 5:26 a.m.)


Review request for mesos and Benjamin Bannier.


Changes
-------

Resolved a test flake more cleanly (IMO).


Bugs: MESOS-9544
    https://issues.apache.org/jira/browse/MESOS-9544


Repository: mesos


Description
-------

This patch extends the code coverage of the `CreateDestroyDisk` and
`CreateDestroyDiskRecovery` tests by testing pipelined `RESERVE`,
`CREATE`, `DESTROY` and `UNRESERVE` operations along with `CREATE_DISK`
and `DESTROY_DISK`. It also renames `CreateDestroyDiskRecovery` to
`CreateDestroyDiskWithRecovery` for consistency.


Diffs (updated)
-----

  src/tests/storage_local_resource_provider_tests.cpp fb001aa8d32d1a0a03014a35772fe10b65ce8d9a



Diff: https://reviews.apache.org/r/69898/diff/2/

Changes: https://reviews.apache.org/r/69898/diff/1-2/


Testing
-------

`make check`

Run in repetition


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message