mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 69893: Clean up persistent volumes on SLRP disks.
Date Tue, 12 Feb 2019 05:18:43 GMT


> On Feb. 5, 2019, 5:55 p.m., Benjamin Bannier wrote:
> > src/resource_provider/storage/provider.cpp
> > Lines 3244 (patched)
> > <https://reviews.apache.org/r/69893/diff/1/?file=2123916#file2123916line3246>
> >
> >     Does this break seemless upgrades? Probably okay, but still something worth
documenting in the upgrades guide.
> 
> Chun-Hung Hsiao wrote:
>     This depends on what we'll do for https://reviews.apache.org/r/69892/#comment298376.
In the current proposal where there are separated boot IDs, this won't introduce any upgrade
issue since it will be empty anyway. During SLRP recovery, it would treat an existing published
volume as `VOL_READY` but not `PUBLISHED` and will call `NodePublishVolume` again. But this
is okay since `NodePublishVolume` is idempotent.

This is a bug fix and will be backported to 1.7.x, so I'm not sure how to properly document
this in `upgrades.md`. I've added some documentation to the commit message, and will also
add that to the MESOS ticket and the CHANGELOG when committing the fix. Would this be enough?


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69893/#review212558
-----------------------------------------------------------


On Feb. 5, 2019, 7:42 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69893/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2019, 7:42 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu.
> 
> 
> Bugs: MESOS-9544
>     https://issues.apache.org/jira/browse/MESOS-9544
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch limits SLRP to only support persistent volumes on MOUNT
> disks, and makes it clean up data in persistent volumes when processing
> `DESTROY` operations.
> 
> 
> Diffs
> -----
> 
>   src/resource_provider/storage/provider.cpp d6e20a549ede189c757ae3ae922ab7cb86d2be2c

>   src/resource_provider/storage/provider_process.hpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/69893/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> More testing done later in chain.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message