mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jason Lai <ja...@jasonlai.net>
Subject Re: Review Request 69286: Allowed creating non-existing host paths for Mesos Containerizer.
Date Mon, 11 Feb 2019 23:10:44 GMT


> On Nov. 8, 2018, 6:33 a.m., Gilbert Song wrote:
> >

Hi, @gilbert. I updated the patch a bit differently than you originally requested by creating
a `PathValidator` that encapsulate the validation logic instead. Please check if this revision
rings a bell to you.


> On Nov. 8, 2018, 6:33 a.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/isolators/volume/host_path.hpp
> > Lines 46 (patched)
> > <https://reviews.apache.org/r/69286/diff/1/?file=2106288#file2106288line46>
> >
> >     s/hostPathWhitelist/forceCreatedHostPaths/g?

Created a validator class for this purpose instead.


> On Nov. 8, 2018, 6:33 a.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/isolators/volume/host_path.cpp
> > Lines 56-57 (patched)
> > <https://reviews.apache.org/r/69286/diff/1/?file=2106289#file2106289line56>
> >
> >     do we still need them if we remove the volume namespace?

I created a `mesos::internal::slave::volume::PathValidator` helper for this purpose instead.


> On Nov. 8, 2018, 6:33 a.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/isolators/volume/host_path.cpp
> > Lines 86 (patched)
> > <https://reviews.apache.org/r/69286/diff/1/?file=2106289#file2106289line86>
> >
> >     I would move the parse() to create()

Done. I created an overloaded constructor that takes a parsed `PathValidator` instance in
the case where `_flags.host_path_volume_force_creation` is not `None`.


> On Nov. 8, 2018, 6:33 a.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/isolators/volume/utils.cpp
> > Lines 31 (patched)
> > <https://reviews.apache.org/r/69286/diff/1/?file=2106291#file2106291line31>
> >
> >     probably we do not need this method?

True. I dropped it in favor of a factory method as part of the `PathValidator` class.


> On Nov. 8, 2018, 6:33 a.m., Gilbert Song wrote:
> > src/slave/flags.cpp
> > Lines 657 (patched)
> > <https://reviews.apache.org/r/69286/diff/1/?file=2106293#file2106293line657>
> >
> >     if directories do not exist

Done.


> On Nov. 8, 2018, 6:33 a.m., Gilbert Song wrote:
> > src/slave/flags.cpp
> > Lines 658-660 (patched)
> > <https://reviews.apache.org/r/69286/diff/1/?file=2106293#file2106293line658>
> >
> >     Remove these lines?

Done.


- Jason


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69286/#review210388
-----------------------------------------------------------


On Nov. 7, 2018, 10:03 p.m., Jason Lai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69286/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2018, 10:03 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Eric Chung, Gilbert Song, Jie Yu, and James
Peach.
> 
> 
> Bugs: MESOS-9009
>     https://issues.apache.org/jira/browse/MESOS-9009
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a new agent flag `--host_path_volume_force_creation` for
> the `volume/host_path` isolator. The flag takes a colon-separated
> whitelist of paths, under which non-existing host paths are allowed to
> be created.
> 
> If the flag is not specified, the isolator behaves in the original way
> of prohibiting all non-existing host paths from being created.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 732368293049b7d9d6f62057344d433637ad44e8 
>   src/Makefile.am c17eae4ff1d019d515f67d81821e933ecb5dc190 
>   src/slave/containerizer/mesos/isolators/volume/host_path.hpp 4b509e91a056381ca90293d16a400ea4368234a3

>   src/slave/containerizer/mesos/isolators/volume/host_path.cpp 88ecf91d91e2bebd484a4ac94510a14b3500dbfb

>   src/slave/containerizer/mesos/isolators/volume/utils.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/volume/utils.cpp PRE-CREATION 
>   src/slave/flags.hpp 29d8b7985ffde57da02b5fe0d3a524e98acc27c8 
>   src/slave/flags.cpp ccaf65029ec2d0e78041fc3992a0bf5ca0798686 
> 
> 
> Diff: https://reviews.apache.org/r/69286/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jason Lai
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message