mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Clement Michaud <>
Subject Re: Review Request 69938: Add resource decorator hook to implicitly allocate mandatory resources.
Date Mon, 11 Feb 2019 20:50:08 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated fév. 11, 2019, 8:50 après-midi)

Review request for mesos and Benjamin Mahler.


Fixed all comments.

Bugs: MESOS-9315

Repository: mesos


This commit introduces a master hook to decorate task resources in
order to allocate a given amount of custom resource if the framework
does not support it yet.

For instance, if one introduces a new custom resource in a cluster
running frameworks not supporting this resource, there will be a mixed
set of tasks consuming and not consuming this resource leading to
isolation issues. By implementing this hook, a default amount can be
allocated for a custom resources on behalf of the framework so that
every tasks end up consuming this resource and Mesos can take it into

This implicit allocation of resource helps introducing a new custom
resource in the clusters because, before this patch, all frameworks
needed to be patched before introducing the new resource while now a
default value can be applied for the frameworks not supporting the
resource yet meaning the patches can be done later.

Diffs (updated)

  include/mesos/hook.hpp 019887095e7845d5a65d133b0f58091d262ec55b 
  src/examples/test_hook_module.cpp c4f449512a4cc150de8a99f44a525b96a2fc1ae2 
  src/hook/manager.hpp b3d4f5198588068d3b28a57cffb3754b55e33b51 
  src/hook/manager.cpp 3e71a26f8c0fcfefecc93d70f8a9d6c2d7fdcc6c 
  src/master/master.cpp b4faf2b077a0288ba36195b7a21402932489d316 
  src/tests/hook_tests.cpp d8aa35e0027d589044bb131b460311721bd36609 




I added a test showing that if a task was missing network_bandwidth resource in the TaskInfo,
the hook injects a default value on behalf of the framework.


Clement Michaud

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message