mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 69946: Updated handleWhitelistFds() to avoid closing FDs with FD_CLOEXEC bit.
Date Mon, 11 Feb 2019 19:33:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69946/
-----------------------------------------------------------

(Updated Feb. 11, 2019, 11:33 a.m.)


Review request for mesos, Andrei Budnik, Jason Lai, Jie Yu, and James Peach.


Changes
-------

Addressed comments.


Repository: mesos


Description
-------

Since this helper is only called right before exec in child process,
and for those open FDs that is set with FD_CLOEXEC flag, they will
be closed during exec, so that we could skip closing these FDs in
the helper. The motivation of this change is to avoid whitelisting
those FDs that have to survive until exec while we do not want to
expose these FDs to user applications.


Diffs (updated)
-----

  3rdparty/libprocess/src/posix/subprocess.hpp 7bbf91e857538c2a030199a529287efa8ef2c604 


Diff: https://reviews.apache.org/r/69946/diff/2/

Changes: https://reviews.apache.org/r/69946/diff/1-2/


Testing
-------


Thanks,

Gilbert Song


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message