mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources.
Date Fri, 08 Feb 2019 20:47:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69890/#review212678
-----------------------------------------------------------


Fix it, then Ship it!




Looks good, after leaving the comment below, I'm left wondering if there's any point in allowing
an empty entry. Seems we may want to consider rejecting that during validation?


src/tests/hierarchical_allocator_tests.cpp
Lines 2357-2374 (patched)
<https://reviews.apache.org/r/69890/#comment298526>

    Both "empty set" and "NullResourcesAllocatable" don't seem to accurately describe what's
done?
    
     // Add a framework which specifies minimum allocatable resources
      // with a single, empty resource.
    
    Single empty seems more appropriate? Come to think of it, should we validate that all
entries are non-empty? There doesn't seem to be any point in allowing an empty entry, since
any single empty entry renders it equivalent to the empty set case?


- Benjamin Mahler


On Feb. 8, 2019, 11:32 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69890/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2019, 11:32 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Meng Zhu.
> 
> 
> Bugs: MESOS-9523
>     https://issues.apache.org/jira/browse/MESOS-9523
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds tests for the behavior of per-framework, per-role
> minimal allocatable resources. We validate the behavior of framework
> minimal allocatable resources below the globally configured limits and
> the behavior of empty filters or minimal resource quantities set up for
> a framework.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp cc88afbad1b4e6bf707cb13b50c964aa01f9a3ee

> 
> 
> Diff: https://reviews.apache.org/r/69890/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message