mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff via Review Board <nore...@reviews.apache.org>
Subject Re: Review Request 69697: Reverted cleanup step of `verify-reviews.py`.
Date Fri, 08 Feb 2019 16:35:18 GMT


> On Jan. 16, 2019, 5:04 p.m., Vinod Kone wrote:
> > support/verify-reviews.py
> > Line 174 (original), 171 (patched)
> > <https://reviews.apache.org/r/69697/diff/1/?file=2118600#file2118600line174>
> >
> >     Do you guys understand why this was failing in the Azure CI in the first place?
Originally, the HEAD variable was calculated outside `cleanup`. But looks like at some point
(during refactor for python3) it was pushed inside `cleanup`. Do you know why?
> >     
> >     Also `git checkout HEAD -- HEAD` is wrong. I don't think that works. Was this
tested?

We are assuming this stems from the fact that the working directory of the invocations differ
- https://reviews.apache.org/r/69817 determines the working directory, we expect/hope/pray
that fixes things.


- Till


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69697/#review212077
-----------------------------------------------------------


On Jan. 9, 2019, 9:30 a.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69697/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2019, 9:30 a.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-9514
>     https://issues.apache.org/jira/browse/MESOS-9514
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Reverts the improvements made on the support script `verify-reviews.py`
> in 3badf7179992e61f30f5a79da9d481dd451c7c2f. Sadly, these changes have
> broken our Azure based Mesos CI as seen in MESOS-9514.
> 
> After comparing the code before and after the commit, we can see that
> the line failing in CI, `HEAD = shell("git rev-parse HEAD")`, is
> misplaced. It was previously located in the exit process in the
> `cleanup()` function and it is now back there, surrounded by a
> try/catch for error handling.
> 
> 
> Diffs
> -----
> 
>   support/verify-reviews.py 72f98b234d9a2a84decb0569998d74e4c730122d 
> 
> 
> Diff: https://reviews.apache.org/r/69697/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message