mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources.
Date Fri, 08 Feb 2019 11:32:57 GMT


> On Feb. 5, 2019, 8:03 p.m., Benjamin Mahler wrote:
> > src/tests/hierarchical_allocator_tests.cpp
> > Lines 2287 (patched)
> > <https://reviews.apache.org/r/69890/diff/1/?file=2123899#file2123899line2287>
> >
> >     any reason not to stick to using "minimum" for these? ditto below
> >     
> >     is "finite" needed here?

Fixed.


> On Feb. 5, 2019, 8:03 p.m., Benjamin Mahler wrote:
> > src/tests/hierarchical_allocator_tests.cpp
> > Lines 2287-2288 (patched)
> > <https://reviews.apache.org/r/69890/diff/1/?file=2123899#file2123899line2287>
> >
> >     suggestion:
> >     
> >     "resources, it correctly overrides the global minimum. We check this by ensuring
it gets an offer when the global minimum is not satisfied but the framework's role specific
mininium is"

Fixed.


> On Feb. 5, 2019, 8:03 p.m., Benjamin Mahler wrote:
> > src/tests/hierarchical_allocator_tests.cpp
> > Lines 2352-2353 (patched)
> > <https://reviews.apache.org/r/69890/diff/1/?file=2123899#file2123899line2352>
> >
> >     Do we actually need these two lines? It seems like having a "set" but empty
`min_allocatable_resources` should be enough? (i.e. without having to add a single array item
within its `quantities`)

Yes, I believe this is needed here. I fixed the test names like pointed out by you below.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69890/#review212563
-----------------------------------------------------------


On Feb. 8, 2019, 12:32 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69890/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2019, 12:32 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Meng Zhu.
> 
> 
> Bugs: MESOS-9523
>     https://issues.apache.org/jira/browse/MESOS-9523
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds tests for the behavior of per-framework, per-role
> minimal allocatable resources. We validate the behavior of framework
> minimal allocatable resources below the globally configured limits and
> the behavior of empty filters or minimal resource quantities set up for
> a framework.
> 
> 
> Diffs
> -----
> 
>   src/tests/hierarchical_allocator_tests.cpp cc88afbad1b4e6bf707cb13b50c964aa01f9a3ee

> 
> 
> Diff: https://reviews.apache.org/r/69890/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message