mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 69889: Stored static framework offer filters in allocator framework class.
Date Fri, 08 Feb 2019 11:32:47 GMT


> On Feb. 5, 2019, 8:13 p.m., Benjamin Mahler wrote:
> > src/master/allocator/mesos/hierarchical.hpp
> > Lines 105 (patched)
> > <https://reviews.apache.org/r/69889/diff/1/?file=2123895#file2123895line105>
> >
> >     Actually, just realized when reading the subsequent patch (and thinking through
what it would mean for the allocatable function to be a member function of the `Framework`
struct) that this field needs to be updated when `HierarchicalAllocatorProcess::updateFramework(...)`
is called.
> >     
> >     Can we also have a test ensuring updateFramework correctly updates it?

I augmented the allocator's `updateFramework` to update this flag, and extended a test later
in the chain to confirm it has the desired effect.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69889/#review212564
-----------------------------------------------------------


On Feb. 8, 2019, 12:32 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69889/
> -----------------------------------------------------------
> 
> (Updated Feb. 8, 2019, 12:32 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Meng Zhu.
> 
> 
> Bugs: MESOS-9523
>     https://issues.apache.org/jira/browse/MESOS-9523
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit unpacks static offer filters configured in `FrameworkInfo`
> into a dedicated field in the allocator-specific `Framework` class which
> uses `ResourceQuantities`.
> 
> When the allocator receives an update on the framework's information it
> will use any newly specified offer filters. This is validated with a
> follow-up patch.
> 
> We will update the allocator to make use of this information in a
> subsequent patch.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.hpp 1420c2638786d85f7b04379e5d79e59990c3e6cf

>   src/master/allocator/mesos/hierarchical.cpp bb9a9c95979f36c0564af5b3babb1c43077a363b

> 
> 
> Diff: https://reviews.apache.org/r/69889/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message