mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 69910: Added tests for feedback for operations on agent default resources.
Date Fri, 08 Feb 2019 00:37:07 GMT


> On Feb. 7, 2019, 4:32 p.m., Greg Mann wrote:
> > src/tests/agent_operation_feedback_tests.cpp
> > Lines 179 (patched)
> > <https://reviews.apache.org/r/69910/diff/2/?file=2124478#file2124478line179>
> >
> >     We should probably advance the clock by a multiple of this, like Benno was doing
in his test. That way, if the acknowledgement is not processed correctly, we would be sure
to hit the retry, since the agent backs off as it retries.

Benno's test advances the clock by a multiple of the minimum interval, this test advances
it by the maximum interval. I manually verified before posting the updated patch that commenting
out the ack call triggers another retry and makes the test fail.


- Gastón


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69910/#review212651
-----------------------------------------------------------


On Feb. 7, 2019, 1:53 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69910/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2019, 1:53 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Joseph Wu.
> 
> 
> Bugs: MESOS-9473
>     https://issues.apache.org/jira/browse/MESOS-9473
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests for feedback for operations on agent default resources.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 3f7daf2cca63c1b9c9e78264f241892327741aa0 
>   src/tests/CMakeLists.txt 42f820715ac43dc70a776f30783d9bc078ef99a5 
>   src/tests/agent_operation_feedback_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/69910/diff/2/
> 
> 
> Testing
> -------
> 
> `bin/mesos-tests.sh--gtest_filter="*AgentOperationFeedbackTest*" --gtest_repeat=5000
--gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message