mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 69922: Added test to verify that frameworks receive OPERATION_DROPPED updates.
Date Fri, 08 Feb 2019 00:33:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69922/#review212653
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/agent_operation_feedback_tests.cpp
Lines 564 (patched)
<https://reviews.apache.org/r/69922/#comment298500>

    Can we also check that the agent ID is set and that the RP ID isn't?


- Gastón Kleiman


On Feb. 7, 2019, 3:23 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69922/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2019, 3:23 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Joseph Wu.
> 
> 
> Bugs: MESOS-9538
>     https://issues.apache.org/jira/browse/MESOS-9538
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds the new test
> `AgentOperationFeedbackTest.DroppedOperationStatusUpdate`
> which verifies that when an operation is dropped on its
> way to the agent, a framework will receive an
> OPERATION_DROPPED status update if it requested feedback
> for that operation.
> 
> 
> Diffs
> -----
> 
>   src/tests/agent_operation_feedback_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/69922/diff/1/
> 
> 
> Testing
> -------
> 
> `bin/mesos-tests.sh --gtest_filter="*DroppedOperationStatusUpdate*" --gtest_repeat=-1
--gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message