mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 69910: Added tests for feedback for operations on agent default resources.
Date Fri, 08 Feb 2019 00:32:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69910/#review212651
-----------------------------------------------------------




src/tests/agent_operation_feedback_tests.cpp
Lines 179 (patched)
<https://reviews.apache.org/r/69910/#comment298499>

    We should probably advance the clock by a multiple of this, like Benno was doing in his
test. That way, if the acknowledgement is not processed correctly, we would be sure to hit
the retry, since the agent backs off as it retries.


- Greg Mann


On Feb. 7, 2019, 9:53 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69910/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2019, 9:53 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Joseph Wu.
> 
> 
> Bugs: MESOS-9473
>     https://issues.apache.org/jira/browse/MESOS-9473
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests for feedback for operations on agent default resources.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 3f7daf2cca63c1b9c9e78264f241892327741aa0 
>   src/tests/CMakeLists.txt 42f820715ac43dc70a776f30783d9bc078ef99a5 
>   src/tests/agent_operation_feedback_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/69910/diff/2/
> 
> 
> Testing
> -------
> 
> `bin/mesos-tests.sh--gtest_filter="*AgentOperationFeedbackTest*" --gtest_repeat=5000
--gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message