mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 69911: Added tests for reconciliation of operations on agent default resources.
Date Thu, 07 Feb 2019 21:57:30 GMT


> On Feb. 7, 2019, 10:09 a.m., Greg Mann wrote:
> > src/tests/operation_reconciliation_tests.cpp
> > Lines 945 (patched)
> > <https://reviews.apache.org/r/69911/diff/1/?file=2124148#file2124148line945>
> >
> >     Use `GetParam()` here?

Already done in https://reviews.apache.org/r/69913/. I squashed both patches.


> On Feb. 7, 2019, 10:09 a.m., Greg Mann wrote:
> > src/tests/operation_reconciliation_tests.cpp
> > Lines 984-985 (patched)
> > <https://reviews.apache.org/r/69911/diff/1/?file=2124148#file2124148line984>
> >
> >     Let's also expect that the resource provider ID is unset in the update.

Done here and elsewhere.


> On Feb. 7, 2019, 10:09 a.m., Greg Mann wrote:
> > src/tests/operation_reconciliation_tests.cpp
> > Lines 987 (patched)
> > <https://reviews.apache.org/r/69911/diff/1/?file=2124148#file2124148line987>
> >
> >     Period at the end of comment, here and elsewhere.

Also fixed already existing comments here: https://reviews.apache.org/r/69919/


- Gastón


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69911/#review212632
-----------------------------------------------------------


On Feb. 7, 2019, 1:55 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69911/
> -----------------------------------------------------------
> 
> (Updated Feb. 7, 2019, 1:55 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Joseph Wu.
> 
> 
> Bugs: MESOS-9473
>     https://issues.apache.org/jira/browse/MESOS-9473
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests for reconciliation of operations on agent default resources.
> 
> 
> Diffs
> -----
> 
>   src/tests/operation_reconciliation_tests.cpp 9a1fc95752c8ce7c7358561bda3659a76871f5c3

> 
> 
> Diff: https://reviews.apache.org/r/69911/diff/2/
> 
> 
> Testing
> -------
> 
> `bin/mesos-tests.sh --gtest_filter="*OperationReconciliationTest*" --gtest_repeat=5000
--gtest_break_on_failure` passed
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message