mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 69910: Added tests for feedback for operations on agent default resources.
Date Thu, 07 Feb 2019 21:52:48 GMT


> On Feb. 7, 2019, 9:24 a.m., Greg Mann wrote:
> > I just realized this test is doing the same thing as `MasterAPITest.OperationFeedbackOnAgentDefaultResources`,
maybe we should just move that one to your new file? Or remove that one and retain this one?

Removing that test in https://reviews.apache.org/r/69920/.


> On Feb. 7, 2019, 9:24 a.m., Greg Mann wrote:
> > src/tests/agent_operation_feedback_tests.cpp
> > Lines 156 (patched)
> > <https://reviews.apache.org/r/69910/diff/1/?file=2124147#file2124147line156>
> >
> >     Is this necessary?

The test passes without it, so it is not necessary =).


- Gastón


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69910/#review212631
-----------------------------------------------------------


On Feb. 6, 2019, 1:02 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69910/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2019, 1:02 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Joseph Wu.
> 
> 
> Bugs: MESOS-9473
>     https://issues.apache.org/jira/browse/MESOS-9473
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests for feedback for operations on agent default resources.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 3f7daf2cca63c1b9c9e78264f241892327741aa0 
>   src/tests/CMakeLists.txt 42f820715ac43dc70a776f30783d9bc078ef99a5 
>   src/tests/agent_operation_feedback_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/69910/diff/1/
> 
> 
> Testing
> -------
> 
> `bin/mesos-tests.sh--gtest_filter="*AgentOperationFeedbackTest*" --gtest_repeat=5000
--gtest_break_on_failure`
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message