mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 69912: Added agent/RP IDs to some operation updates generated by the master.
Date Thu, 07 Feb 2019 19:53:38 GMT


> On Feb. 7, 2019, 10:15 a.m., Greg Mann wrote:
> > src/master/master.cpp
> > Lines 9089 (patched)
> > <https://reviews.apache.org/r/69912/diff/1/?file=2124156#file2124156line9089>
> >
> >     s/Some(resourceProviderId.get())/resourceProviderId/

Note that `resourceProviderId` is a `Result` and not an `Option`, so the compiler won't like
that:

```
../src/master/master.cpp:9088:11: error: no viable conversion from 'Result<mesos::ResourceProviderID>'
to 'const Option<mesos::ResourceProviderID>'
          resourceProviderId.isSome()
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~
```


- Gastón


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69912/#review212634
-----------------------------------------------------------


On Feb. 6, 2019, 2:04 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69912/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2019, 2:04 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Joseph Wu.
> 
> 
> Bugs: MESOS-9559
>     https://issues.apache.org/jira/browse/MESOS-9559
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch makes the master include the agent and resource provider IDs
> in the OPERATION_GONE_BY_OPERATOR and OPERATION_UNREACHABLE operation
> status updates that it generates.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 4c9ef2528d0ab74b565dcb03d05c5189d0aa0c0f 
> 
> 
> Diff: https://reviews.apache.org/r/69912/diff/1/
> 
> 
> Testing
> -------
> 
> `bin/mesos-tests.sh` passed
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message