mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Mann <g...@mesosphere.io>
Subject Re: Review Request 69913: Added more operation reconciliation tests.
Date Thu, 07 Feb 2019 18:32:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69913/#review212635
-----------------------------------------------------------


Fix it, then Ship it!




Nit: the commit message says that "tests" are added, but there is only one test in this patch.


src/tests/operation_reconciliation_tests.cpp
Lines 943-945 (original), 943-947 (patched)
<https://reviews.apache.org/r/69913/#comment298462>

    Ah, looks like this part of the diff belongs in a previous patch.



src/tests/operation_reconciliation_tests.cpp
Lines 1244 (patched)
<https://reviews.apache.org/r/69913/#comment298463>

    I think the detector isn't necessary in this test?



src/tests/operation_reconciliation_tests.cpp
Lines 1320-1321 (patched)
<https://reviews.apache.org/r/69913/#comment298464>

    Should we also expect that RP ID is unset?



src/tests/operation_reconciliation_tests.cpp
Lines 1352-1353 (patched)
<https://reviews.apache.org/r/69913/#comment298465>

    Ditto regarding RP ID.



src/tests/operation_reconciliation_tests.cpp
Lines 1355 (patched)
<https://reviews.apache.org/r/69913/#comment298466>

    Nit: period at the end of comment. Here and below.



src/tests/operation_reconciliation_tests.cpp
Lines 1383 (patched)
<https://reviews.apache.org/r/69913/#comment298467>

    Could you explain in this comment why the response contains no operation statuses?


- Greg Mann


On Feb. 6, 2019, 10:04 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69913/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2019, 10:04 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Joseph Wu.
> 
> 
> Bugs: MESOS-9473
>     https://issues.apache.org/jira/browse/MESOS-9473
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added more operation reconciliation tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/operation_reconciliation_tests.cpp 9a1fc95752c8ce7c7358561bda3659a76871f5c3

> 
> 
> Diff: https://reviews.apache.org/r/69913/diff/1/
> 
> 
> Testing
> -------
> 
> `GLOG_v=1 bin/mesos-tests.sh --verbose --gtest_filter="*OperationReconciliationTest*"`
passed
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message