mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 69898: Updated `CreateDestroyDisk*` SLRP tests to test pipelined operations.
Date Wed, 06 Feb 2019 02:04:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69898/#review212587
-----------------------------------------------------------



Patch looks great!

Reviews applied: [69858, 69866, 69892, 69893, 69894, 69895, 69896, 69897, 69898]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1';
./support/docker-build.sh

- Mesos Reviewbot


On Feb. 5, 2019, 8:06 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69898/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2019, 8:06 a.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Bugs: MESOS-9544
>     https://issues.apache.org/jira/browse/MESOS-9544
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch extends the code coverage of the `CreateDestroyDisk` and
> `CreateDestroyDiskRecovery` tests by testing pipelined `RESERVE`,
> `CREATE`, `DESTROY` and `UNRESERVE` operations along with `CREATE_DISK`
> and `DESTROY_DISK`. It also renames `CreateDestroyDiskRecovery` to
> `CreateDestroyDiskWithRecovery` for consistency.
> 
> 
> Diffs
> -----
> 
>   src/tests/storage_local_resource_provider_tests.cpp e8ed20f818ed7f1a3ce15758ea3c366520443377

> 
> 
> Diff: https://reviews.apache.org/r/69898/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> Run in repetition
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message