mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Re: Review Request 69858: Persisted intentionally dropped operations in SLRP.
Date Wed, 06 Feb 2019 00:04:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69858/
-----------------------------------------------------------

(Updated Feb. 6, 2019, 12:04 a.m.)


Review request for mesos, Benjamin Bannier, Gastón Kleiman, and Greg Mann.


Changes
-------

Addressed Benjamin's comments and fixed a bug.


Bugs: MESOS-9537
    https://issues.apache.org/jira/browse/MESOS-9537


Repository: mesos


Description
-------

If an operation is dropped intentionally (e.g., because of a resource
version mismatch), the operation should be persisted so no conflicting
status update would be generated for operation reconciliation.


Diffs (updated)
-----

  src/resource_provider/storage/provider.cpp d6e20a549ede189c757ae3ae922ab7cb86d2be2c 
  src/resource_provider/storage/provider_process.hpp PRE-CREATION 


Diff: https://reviews.apache.org/r/69858/diff/4/

Changes: https://reviews.apache.org/r/69858/diff/3-4/


Testing
-------

`make check`

Additional test MESOS-9537 is added later in chain.


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message