mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 69818: Added offer filters to static framework configuration.
Date Mon, 04 Feb 2019 11:15:12 GMT


> On Jan. 29, 2019, 9:14 p.m., Benjamin Mahler wrote:
> > I think you missed my top level comment from the last review to add context to the
commit about the min allocatable flag and how this is providing a per-framework/role override
of that global flag?
> > 
> > Also, we're missing a patch for the master to allow changing the value upon framework
re-registration?
> 
> Benjamin Bannier wrote:
>     Re:commit message, see my comment here, https://reviews.apache.org/r/69818/#comment298165.
>     
>     Re:changing the offer_filters, updated this patch.

Updated commit message.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69818/#review212419
-----------------------------------------------------------


On Feb. 4, 2019, 12:14 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69818/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2019, 12:14 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Meng Zhu.
> 
> 
> Bugs: MESOS-9523
>     https://issues.apache.org/jira/browse/MESOS-9523
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds a new field to `FrameworkInfo` which can be used by
> frameworks to configure static, per-role resource requirements. We
> currently support specifying minimal allocatable resources which is
> interpreted by the default, hierarchical allocator for filtering out
> resources not relevant to the framework, and for overriding any globally
> configured `min_allocatable_resources` on a per framework, per role
> basis.
> 
> We use a new message `ResourceQuantities` to specify resource
> requirements. This class is modelled after the internal class of the
> same name, and we provide a conversion from the API to the internal
> type.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 9d5c2b53164adb44eb4a6f12a507e009bd607940 
>   include/mesos/v1/mesos.proto aef31eb5b8781182d3f42d935b12470b319027ed 
>   src/common/resource_quantities.hpp 11eb426104577bbbbb7977c2307df3e4917085cd 
>   src/common/resource_quantities.cpp 320983929cd7d14973c4b98d6ed5338de690ff5f 
>   src/master/framework.cpp 4089cf4dfc65ac4dc5a092c04f4c2022ed8a1587 
> 
> 
> Diff: https://reviews.apache.org/r/69818/diff/7/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message