mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <>
Subject Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.
Date Mon, 04 Feb 2019 11:14:37 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Feb. 4, 2019, 12:14 p.m.)

Review request for mesos, Benjamin Mahler and Meng Zhu.


Add a clarifying comment

Bugs: MESOS-9523

Repository: mesos


This patch modifies the hierarchical allocator to take
framework-specified minimal allocatable resources into account.

While previously the allocator was inspecting the minimal allocatable
resources specified in its global options, it can now also inspects
framework-specific resource requirements. With that frameworks can e.g.,
configure resource requirements above the default minimal allocatable
resource, or opt into receiving resources considered too small to be
allocatable by the allocator in its default behavior.

For that we change the hierarchical allocator's `allocatable` function
to be framework and role-specific. As that does in some places not allow
us to abort iterating over candidate resource consumers like before an
additional check on whether any resources are left in an allocation
cycle is added as a break condition.

Diffs (updated)

  src/master/allocator/mesos/hierarchical.hpp 1420c2638786d85f7b04379e5d79e59990c3e6cf 
  src/master/allocator/mesos/hierarchical.cpp bb9a9c95979f36c0564af5b3babb1c43077a363b 
  src/master/framework.cpp 4089cf4dfc65ac4dc5a092c04f4c2022ed8a1587 
  src/tests/hierarchical_allocator_tests.cpp cc88afbad1b4e6bf707cb13b50c964aa01f9a3ee 




`make check`

File Attachments

Ratio new/old timings


Benjamin Bannier

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message