mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 69862: Validated static framework offer filters.
Date Mon, 04 Feb 2019 11:14:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69862/
-----------------------------------------------------------

(Updated Feb. 4, 2019, 12:14 p.m.)


Review request for mesos, Benjamin Mahler and Meng Zhu.


Changes
-------

Add validation to exclude NaN and inf values


Bugs: MESOS-9523
    https://issues.apache.org/jira/browse/MESOS-9523


Repository: mesos


Description
-------

This patch adds validation to framework-specified static offer filters.
In particular we enforce that minimal resource quantities cannot be
negative.


Diffs (updated)
-----

  src/common/validation.hpp 5929ac24fa7d7d2f7f08bc30c5071716e6cf46cb 
  src/common/validation.cpp 4a64fc8ac83fd741eb2cbc70772322b347dbcb4e 
  src/master/validation.hpp a5bdff6a9301631dac9970568a1346460939c861 
  src/master/validation.cpp 7e688bb657cd44f98f082b5efe7178edcb7ce595 
  src/tests/common_validation_tests.cpp 97466ab38f3156155655520c81b17cc6ec2cd779 
  src/tests/master_validation_tests.cpp c00e8bb315c28bdf438da2089dd81f5e348982e5 


Diff: https://reviews.apache.org/r/69862/diff/3/

Changes: https://reviews.apache.org/r/69862/diff/2-3/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message