From reviews-return-84574-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Mon Jan 14 08:57:21 2019 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 84723188B8 for ; Mon, 14 Jan 2019 08:57:21 +0000 (UTC) Received: (qmail 54693 invoked by uid 500); 14 Jan 2019 08:57:21 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 54660 invoked by uid 500); 14 Jan 2019 08:57:21 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 54643 invoked by uid 99); 14 Jan 2019 08:57:19 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 Jan 2019 08:57:19 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 8817E180635; Mon, 14 Jan 2019 08:57:19 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.152 X-Spam-Level: *** X-Spam-Status: No, score=3.152 tagged_above=-999 required=6.31 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_REPLYTO_END_DIGIT=0.25, HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 4Xoz5umj-2Nl; Mon, 14 Jan 2019 08:57:18 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 6052760CFF; Mon, 14 Jan 2019 08:57:18 +0000 (UTC) Received: from reviews.apache.org (unknown [10.41.0.12]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id CBD85E13DA; Mon, 14 Jan 2019 08:57:12 +0000 (UTC) Received: from reviews-vm2.apache.org (localhost [IPv6:::1]) by reviews.apache.org (ASF Mail Server at reviews-vm2.apache.org) with ESMTP id B8ECEC4082D; Mon, 14 Jan 2019 08:57:12 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1568428092757422055==" MIME-Version: 1.0 Subject: Re: Review Request 69735: Fixed maintenance causes machines not in schedule rescinding offers. From: Gilbert Song To: Benno Evers Cc: fei long , mesos Date: Mon, 14 Jan 2019 08:57:12 -0000 Message-ID: <20190114085712.64748.24259@reviews-vm2.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: Gilbert Song X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/69735/ X-Sender: Gilbert Song References: <20190114033420.415.76097@reviews-vm2.apache.org> In-Reply-To: <20190114033420.415.76097@reviews-vm2.apache.org> Reply-To: Gilbert Song X-ReviewRequest-Repository: mesos --===============1568428092757422055== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69735/#review211948 ----------------------------------------------------------- Is `MasterAPITest.OperationUpdatesUponAgentGone/1` failure releted to the change? - Gilbert Song On Jan. 13, 2019, 7:34 p.m., fei long wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69735/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2019, 7:34 p.m.) > > > Review request for mesos and Benno Evers. > > > Bugs: MESOS-9394 > https://issues.apache.org/jira/browse/MESOS-9394 > > > Repository: mesos > > > Description > ------- > > Fixed maintenance causes machines not in schedule rescinding offers. > > > Diffs > ----- > > src/master/http.cpp 012ee4f205ab3f2678b058fb0f3ebdac4336eca4 > > > Diff: https://reviews.apache.org/r/69735/diff/1/ > > > Testing > ------- > > > Thanks, > > fei long > > --===============1568428092757422055==--