-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69862/#review212490
-----------------------------------------------------------
Fix it, then Ship it!
src/common/validation.cpp
Lines 629-632 (patched)
<https://reviews.apache.org/r/69862/#comment298250>
Should we also disallow NaN and +inf? (along with tests for these cases?)
- Benjamin Mahler
On Jan. 31, 2019, 3:15 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69862/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2019, 3:15 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Meng Zhu.
>
>
> Bugs: MESOS-9523
> https://issues.apache.org/jira/browse/MESOS-9523
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds validation to framework-specified static offer filters.
> In particular we enforce that minimal resource quantities cannot be
> negative.
>
>
> Diffs
> -----
>
> src/common/validation.hpp 5929ac24fa7d7d2f7f08bc30c5071716e6cf46cb
> src/common/validation.cpp 4a64fc8ac83fd741eb2cbc70772322b347dbcb4e
> src/master/validation.hpp a5bdff6a9301631dac9970568a1346460939c861
> src/master/validation.cpp 7e688bb657cd44f98f082b5efe7178edcb7ce595
> src/tests/common_validation_tests.cpp 97466ab38f3156155655520c81b17cc6ec2cd779
> src/tests/master_validation_tests.cpp c00e8bb315c28bdf438da2089dd81f5e348982e5
>
>
> Diff: https://reviews.apache.org/r/69862/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
|